nixos/systemd-boot: guard assertion messages against eval failures#320850
Merged
JulienMalka merged 1 commit intoNixOS:masterfrom Jun 18, 2024
Merged
nixos/systemd-boot: guard assertion messages against eval failures#320850JulienMalka merged 1 commit intoNixOS:masterfrom
JulienMalka merged 1 commit intoNixOS:masterfrom
Conversation
These messages should be able to be printed in all cases. In particular, trying to coerce a `null` to a string is an error unless passed through `toString`.
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Guarded assertion messages in
nixos/modules/system/boot/loader/systemd-boot/systemd-boot.nixagainst eval failures. These messages should be able to be printed in all cases. In particular, trying to coerce anullto a string is an error unless passed throughtoString.I encountered this while testing #313497.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)